https://bugzilla.redhat.com/show_bug.cgi?id=2358954 Fabio Valentini <decathorpe@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |decathorpe@xxxxxxxxx Assignee|nobody@xxxxxxxxxxxxxxxxx |decathorpe@xxxxxxxxx Flags| |fedora-review? --- Comment #7 from Fabio Valentini <decathorpe@xxxxxxxxx> --- This project is ... weird? 1. The license files are in a hidden folder. They are identical (as far as I can tell) except the copyright attribution line. The Apache-2.0 license does *not* have a "Copyright (xxxx) Foo Bar" in the canonical copy, so it is strange to add it "downstream". The MIT license could just have "Copyright (xxxx-yyyy) Foo, (yyyy-zzzz) Bar" instead of containing the license text twice. Do you think it would be possible to make some suggestions to upstream (i.e. drop nonstandard Copyright lines from the Apache license text and move *one* copy to /LICENSE-APACHE, and merge the Copyright lines from the MIT license texts and move it to /LICENSE-MIT)? 2. There's a bunch of files included in published crates that are not interesting to downstream users. It would be great if they were excluded upstream, but excluding them downstream for now would be fine: - /documents/ - /tests/yaml-test-suite/ - /.cargo/ - /.github/ - /appveyor.yml - /garden.yaml - /justfile 3. The crate seems to include a vendored copy of the "yaml-test-suite" project, which is a bunch of Perl and Bash scripts (which also result in dependencies for /usr/bin/perl and /usr/bin/bash to get generated for the -devel package), a bunch of test input data, and it is also covered by a different license (MIT only). It looks like the /tests/yaml-test-suite/ folder should just not be included in published crates. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2358954 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202358954%23c7 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
