https://bugzilla.redhat.com/show_bug.cgi?id=2350109 --- Comment #38 from Pramod V U <pramodvu1502@xxxxxxxxx> --- I am writing this by referring to the fedora-review output above: Whatever is "fixed" (not "already fixed") here will come soon in the next spec-file though... ``` systemd-cron.x86_64: W: tmpfile-not-in-filelist /var/spool/cron ``` I omitted it from the filelist for a reason; It needs to be created *after* systemd-sysusers creates the required group "crontab". ``` systemd-cron.x86_64: W: summary-not-capitalized systemd generator to provide cron daemon & anacron functionality ``` Fixed ``` systemd-cron.x86_64: E: spelling-error ('anacron', 'Summary(en_US) anacron -> macron') systemd-cron.x86_64: E: spelling-error ('anacron', '%description -l en_US anacron -> macron') ``` Also fixed by writing "(ana)cron" (mostly) ``` systemd-cron.x86_64: E: setgid-binary /usr/libexec/systemd-cron/crontab_setgid root 2755 ``` What's the issue here? That binary is *supposed* to be setgid... ``` systemd-cron.x86_64: W: post-without-tmpfile-creation /usr/lib/tmpfiles.d/systemd-cron.conf ``` I know that I am missing a macro here, but IDK what... ``` systemd-cron.x86_64: W: percent-in-%preun systemd-cron.x86_64: W: percent-in-%postun systemd-cron.x86_64: W: percent-in-%post ``` Well, %systemd_ macros for their intended purpose... ``` systemd-cron.x86_64: E: non-standard-executable-perm /usr/libexec/systemd-cron/crontab_setgid 2755 ``` That binary is *supposed* to be setgid... ``` systemd-cron-debuginfo.x86_64: E: no-changelogname-tag systemd-cron.x86_64: E: no-changelogname-tag ``` Already fixed in existing specfile ``` systemd-cron.x86_64: W: files-duplicate /usr/share/licenses/systemd-cron/LICENSE /usr/share/doc/systemd-cron/COPYING ``` Already fixed, by removing COPYING altogether. ``` systemd-cron.x86_64: E: description-line-too-long Provides a systemd generator to run cron jobs in /etc/cron.hourly cron.daily cron.weekly and cron.monthly directories, crontab etc.. ``` Already fixed. `BuildRequires: systemd-rpm-macros` is already there by now Thanks for %{_systemdgeneratordir}, but is the "d" there or is it just %{_systemgeneratordir}? -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2350109 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202350109%23c38 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
