https://bugzilla.redhat.com/show_bug.cgi?id=2350109 --- Comment #31 from Pramod V U <pramodvu1502@xxxxxxxxx> --- I have left %build as-it-is, with minor formatting fixes in the comments... I have also added BuildRequires to the systemd RPM macros package... I have also done a series of `sed -i 's/\/bin/\%\{\_bindir\}/g' systemd-cron.spec`, for `/bin` as `%{_bindir}`, `/usr/libexec` as `%{_libexecdir}`, `/usr/lib/systemd/system` as `%{_unitdir}`, etc... Also cleared out the unused commented-out parts of the %install scriptlet, added appropriate quotes around all paths... I also rewrote all the calls to `systemctl` with macros... EXCEPT the `systemctl reload-or-restart systemd-tmpfiles.service systemd-sysusers.service`; I didn't quite understand which macro does that... I'll remove it if it's not needed... I didn't yet do the change to %buildroot, If the SRPM is built into a binary on another system, and for whatever reason the buildroot is chosen/calculated differently, then won't the script have %buildroot hardcoded to the old value? While RPM_BUILD_ROOT has a newer value? If I am wrong here, kindly inform me. I'll right away change it with `sed -i 's/\$\{RPM\_BUILD\_ROOT\}/\%\{buildroot\}/g' systemd-cron.spec` -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2350109 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202350109%23c31 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
