https://bugzilla.redhat.com/show_bug.cgi?id=2350109 Dick Marinus <dick@xxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|nobody@xxxxxxxxxxxxxxxxx |dick@xxxxxxx Flags| |fedora-review? --- Comment #25 from Dick Marinus <dick@xxxxxxx> --- This is the output from fedora-review: Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. Note: No gcc, gcc-c++ or clang found in BuildRequires See: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/ - Dist tag is present. - Permissions on files are set properly. Note: See rpmlint output See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#_file_permissions - If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. Note: License file COPYING is not marked as %license See: https://docs.fedoraproject.org/en-US/packaging- guidelines/LicensingGuidelines/#_license_text - systemd_post is invoked in %post, systemd_preun in %preun, and systemd_postun in %postun for Systemd service files. Note: Systemd service file(s) in systemd-cron See: https://docs.fedoraproject.org/en-US/packaging- guidelines/Scriptlets/#_scriptlets ===== MUST items ===== C/C++: [ ]: Package does not contain kernel modules. [x]: Package does not contain any libtool archives (.la) [x]: Package contains no static executables. [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "MIT License", "BSD 0-Clause License and/or MIT License", "*No copyright* MIT License", "*No copyright* BSD 0-Clause License". 57 files have unknown license. Detailed output of licensecheck in /home/meeuw/2350109-systemd-cron/licensecheck.txt [x]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /etc/cron.d(cronie) [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [ ]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [x]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 26779 bytes in 3 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: There are rpmlint messages (see attachment). [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: systemd-cron-2.5.1-1.fc43.x86_64.rpm systemd-cron-2.5.1-1.fc43.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.7.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpisf2qz4r')] checks: 32, packages: 2 systemd-cron.spec:15: W: unversioned-explicit-provides cronie systemd-cron.spec:16: W: unversioned-explicit-provides cronie-anacron systemd-cron.x86_64: W: tmpfile-not-in-filelist /var/spool/cron systemd-cron.src: W: summary-not-capitalized systemd generator to provide cron daemon & anacron functionality systemd-cron.x86_64: W: summary-not-capitalized systemd generator to provide cron daemon & anacron functionality systemd-cron.src: E: spelling-error ('anacron', 'Summary(en_US) anacron -> macron') systemd-cron.src: E: spelling-error ('crontab', '%description -l en_US crontab -> contactable') systemd-cron.src: E: spelling-error ('anacron', '%description -l en_US anacron -> macron') systemd-cron.x86_64: E: spelling-error ('anacron', 'Summary(en_US) anacron -> macron') systemd-cron.x86_64: E: spelling-error ('anacron', '%description -l en_US anacron -> macron') systemd-cron.x86_64: E: setgid-binary /usr/libexec/systemd-cron/crontab_setgid root 2755 systemd-cron.x86_64: W: post-without-tmpfile-creation /usr/lib/tmpfiles.d/systemd-cron.conf systemd-cron.x86_64: W: percent-in-%preun systemd-cron.x86_64: W: percent-in-%postun systemd-cron.x86_64: W: percent-in-%post systemd-cron.x86_64: E: non-standard-executable-perm /usr/libexec/systemd-cron/crontab_setgid 2755 systemd-cron.src: E: no-changelogname-tag systemd-cron.x86_64: E: no-changelogname-tag systemd-cron.spec: W: no-%check-section systemd-cron.x86_64: W: files-duplicate /usr/share/licenses/systemd-cron/LICENSE /usr/share/doc/systemd-cron/COPYING systemd-cron.src: E: description-line-too-long Provides a systemd generator to run cron jobs in /etc/cron.hourly cron.daily cron.weekly and cron.monthly directories, crontab etc.. systemd-cron.x86_64: E: description-line-too-long Provides a systemd generator to run cron jobs in /etc/cron.hourly cron.daily cron.weekly and cron.monthly directories, crontab etc.. systemd-cron.spec:55: W: configure-without-libdir-spec 2 packages and 0 specfiles checked; 11 errors, 12 warnings, 13 filtered, 11 badness; has taken 0.5 s Rpmlint (debuginfo) ------------------- Checking: systemd-cron-debuginfo-2.5.1-1.fc43.x86_64.rpm ============================ rpmlint session starts ============================ rpmlint: 2.7.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpd4folgmu')] checks: 32, packages: 1 systemd-cron-debuginfo.x86_64: E: no-changelogname-tag 1 packages and 0 specfiles checked; 1 errors, 0 warnings, 14 filtered, 1 badness; has taken 0.4 s Rpmlint (installed packages) ---------------------------- /bin/sh: warning: setlocale: LC_ALL: cannot change locale (en_US.UTF-8): No such file or directory /bin/sh: warning: setlocale: LC_ALL: cannot change locale (en_US.UTF-8): No such file or directory /bin/sh: warning: setlocale: LC_ALL: cannot change locale (en_US.UTF-8): No such file or directory /bin/sh: warning: setlocale: LC_ALL: cannot change locale (en_US.UTF-8): No such file or directory ============================ rpmlint session starts ============================ rpmlint: 2.7.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 2 systemd-cron.x86_64: W: tmpfile-not-in-filelist /var/spool/cron systemd-cron.x86_64: W: summary-not-capitalized systemd generator to provide cron daemon & anacron functionality systemd-cron.x86_64: E: spelling-error ('anacron', 'Summary(en_US) anacron -> macron') systemd-cron.x86_64: E: spelling-error ('anacron', '%description -l en_US anacron -> macron') systemd-cron.x86_64: E: setgid-binary /usr/libexec/systemd-cron/crontab_setgid root 2755 systemd-cron.x86_64: W: post-without-tmpfile-creation /usr/lib/tmpfiles.d/systemd-cron.conf systemd-cron.x86_64: W: percent-in-%preun systemd-cron.x86_64: W: percent-in-%postun systemd-cron.x86_64: W: percent-in-%post systemd-cron.x86_64: E: non-standard-executable-perm /usr/libexec/systemd-cron/crontab_setgid 2755 systemd-cron-debuginfo.x86_64: E: no-changelogname-tag systemd-cron.x86_64: E: no-changelogname-tag systemd-cron.x86_64: W: files-duplicate /usr/share/licenses/systemd-cron/LICENSE /usr/share/doc/systemd-cron/COPYING systemd-cron.x86_64: E: description-line-too-long Provides a systemd generator to run cron jobs in /etc/cron.hourly cron.daily cron.weekly and cron.monthly directories, crontab etc.. 2 packages and 0 specfiles checked; 7 errors, 7 warnings, 20 filtered, 7 badness; has taken 1.5 s Source checksums ---------------- https://github.com/systemd-cron/systemd-cron/archive/v2.5.1.tar.gz : CHECKSUM(SHA256) this package : 5453566e44b88cc9de6fc1933644b8fdfcd93d2814893548de09a12f865a8870 CHECKSUM(SHA256) upstream package : 5453566e44b88cc9de6fc1933644b8fdfcd93d2814893548de09a12f865a8870 Requires -------- systemd-cron (rpmlib, GLIBC filtered): /bin/sh /usr/bin/sh crontabs libc.so.6()(64bit) libm.so.6()(64bit) libmd.so.0()(64bit) libmd.so.0(LIBMD_0.0)(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.9)(64bit) rtld(GNU_HASH) systemd Provides -------- systemd-cron: cronie cronie-anacron group(_cron-failure) group(crontab) systemd-cron systemd-cron(x86-64) user(_cron-failure) Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/usr/bin/fedora-review -b 2350109 Buildroot used: fedora-rawhide-x86_64 Active plugins: Shell-api, Generic, C/C++ Disabled plugins: Perl, R, PHP, Ocaml, Haskell, fonts, SugarActivity, Python, Java Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH ==== This is my first review so bear with me. 1. configure is fine in %build, there's also %configure I'm not sure if you should use that. 2. consider using %buildroot instead of using $RPM_BUILD_ROOT 3. %changelog is missing 4. the description is too long -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2350109 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202350109%23c25 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
