https://bugzilla.redhat.com/show_bug.cgi?id=2354888 --- Comment #43 from Nils Philippsen <nphilipp@xxxxxxxxxx> --- Spec URL: https://nphilipp.fedorapeople.org/review/forgejo/8/forgejo.spec SRPM URL: https://nphilipp.fedorapeople.org/review/forgejo/8/forgejo-11.0.1-1.fc43.src.rpm This updates to version 11.0.1. (In reply to Maxwell G from comment #40) > I'm sorry; I'm very busy this week. Could Neal or Zbyszek give the final > approval? The only potential remaining issue is licensing or bundled() > Provides for any web assets; I'm not sure about the current Guidelines for > web assets (I believe FESCo/FPC agreed to loosen them again relatively > recently) and haven't confirmed whether these do exist in the source (but I > assume so). Other small things: > > - Is the nodejs BR used? > - Please remove the manual go-vendor-tools+scancode BuildRequires. This is > already handled by %go_vendor_license_buildrequires. I’ve removed both. > - Is the robots.txt that disallows every single crawler (User-agent: * and > Disallow: /) something we want to ship in the package? That seems pretty > opinionated. It is opinionated, but it’s also a safe default (that users can change) if a system is inadvertently exposed. (In reply to Neal Gompa from comment #42) > > # We don’t use go macros to build, but this is what they do to prevent binutils-style-ld flags to > > # mess things up for the Go linker. > > %undefine _auto_set_build_flags > > This shouldn't be needed anymore either. I’ve removed this, too. (In reply to Neal Gompa from comment #41) > We do need the bundled provides for nodejs stuff too. I’m trying to find out how to do this (and %license …) sensibly, would nodejs-packaging-bundler do that normally? Anyway, the source tarball doesn’t seem to have the structure of a nodejs package expected by it. 😬 Do we have tooling that would help me there? I‘m also not sure if we should rather rebuild the vendorized node sources rather than take the pre-build (minified etc.) files from the tarball. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2354888 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202354888%23c43 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
