https://bugzilla.redhat.com/show_bug.cgi?id=2363088 --- Comment #9 from John Whitington <john@xxxxxxxxxxxxxxxxxxxxxx> --- Right. It seems that the OCamlMakefile part of the patch (where we pass -ccopt "-o2 -g" even when building with -custom): a) Isn't required for the mockbuild debuginfo extraction to succeed. Just fixing Makefile alone fixes that. b) Means that when I build cpdf (which uses camlpdf) I get a cpdf.dSYM folder created, which was not previously the case. Is that good? c) -o2 here causes problems. So if we keep the OCamlMakefile part of the patch, we need to drop -o2. Which is fine. Here, for reference is the patch: --- Makefile.orig 2025-05-03 14:53:49.000000000 +0100 +++ Makefile 2025-05-03 14:53:30.000000000 +0100 @@ -10,7 +10,7 @@ RESULT = camlpdf -CFLAGS = -o2 +CFLAGS = -o2 -g OCAMLFLAGS = -bin-annot OCAMLNCFLAGS = -g -safe-string OCAMLBCFLAGS = -g -safe-string --- OCamlMakefile.orig 2025-05-03 16:07:01.000000000 +0100 +++ OCamlMakefile 2025-05-03 16:06:47.000000000 +0100 @@ -614,7 +614,7 @@ ifneq ($(strip $(OBJ_LINK)),) ifdef CREATE_LIB - OBJS_LIBS := -cclib -l$(CLIB_BASE) $(CLIBS_OPTS) $(MAYBE_IDL) + OBJS_LIBS := -ccopt "$(CFLAGS)" -cclib -l$(CLIB_BASE) $(CLIBS_OPTS) $(MAYBE_IDL) else OBJS_LIBS := $(OBJ_LINK) $(CLIBS_OPTS) $(MAYBE_IDL) endif -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2363088 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202363088%23c9 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
