https://bugzilla.redhat.com/show_bug.cgi?id=2362370 Peter Lemenkov <lemenkov@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(lemenkov@xxxxxxxx | |m) | --- Comment #16 from Peter Lemenkov <lemenkov@xxxxxxxxx> --- (In reply to Tomi Lähteenmäki from comment #15) > > Amazing tool! Exactly what I wanted. > > Yes, I wish I would have noticed the retirement earlier! Also apostrophe was > retired, it would be in GNOME Circle but the reason for retirement made > Marker better candidate (also being written in C so I find it more suitable > for me to maintain). > > > Please, comment/address my notes above and we'll finish this. > > I admit that I just reverted the retirement commit and fixed the FTBFS and > glanced through of the spec. > > > Please ensure ownersip of /usr/lib/Marker.extensions directory > > Done: > https://codeberg.org/Lihis/marker/commit/ > a6ae37e7f76a58812029f63a679bcfa138fd3e64 Ok. > > Versioning should be just 2023.05.02 I believe. > > Latest release at GitHub is just `2023.05.02` so yes, it should: > https://codeberg.org/Lihis/marker/commit/ > 4495f7bf0ccf4bb41c620730fa929b784358f973 Ok, good. > > We have 3 more LICENSE files from Source[123]. Consider packing them as well. NOT A BLOCKER. > > How this should be handled? Just `cp` the licenses to > `%{_licensedir}/marker/`? I believe that's the onl way. Something ugly like this: ``` %autosetup -n Marker-%{version} -D -T -a1 -N %autosetup -n Marker-%{version} -D -T -a2 -N %autosetup -n Marker-%{version} -D -T -a3 -N cp scidown-%{submodule1_commit}/LICENSE LICENSE.scidown cp charter-%{submodule2_commit}/LICENSE LICENSE.charter cp tinyexpr-%{submodule3_commit}/LICENSE LICENSE.tinyexpr ``` -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2362370 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202362370%23c16 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
