[Bug 2363088] Review Request: ocaml-camlpdf - OCaml library for reading, writing, and modifying PDFs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2363088

Richard W.M. Jones <rjones@xxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |rjones@xxxxxxxxxx



--- Comment #2 from Richard W.M. Jones <rjones@xxxxxxxxxx> ---
Instead of the ExcludeArch, use:

ExclusiveArch: %{ocaml_native_compiler}

(assuming, as you probably do, you want to ignore bytecode arches).  This macro
is provided by this package and updated regularly:

https://src.fedoraproject.org/rpms/ocaml-srpm-macros/commits/rawhide

Unless there's a very good reason, you should drop this:

%global debug_package %{nil}

Your build system should be fixed to make sure that -g is passed to every
compiler invocation
(maybe with a configure-time switch to turn this on or off if you prefer).

Also I'm confused about why you need to limit _smp_ncpus_max to 1, what is the
reason for that?


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2363088

Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202363088%23c2

-- 
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux