https://bugzilla.redhat.com/show_bug.cgi?id=2354888 Maxwell G <maxwell@xxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(maxwell@xxxxxxx) | --- Comment #40 from Maxwell G <maxwell@xxxxxxx> --- I'm sorry; I'm very busy this week. Could Neal or Zbyszek give the final approval? The only potential remaining issue is licensing or bundled() Provides for any web assets; I'm not sure about the current Guidelines for web assets (I believe FESCo/FPC agreed to loosen them again relatively recently) and haven't confirmed whether these do exist in the source (but I assume so). Other small things: - Is the nodejs BR used? - Please remove the manual go-vendor-tools+scancode BuildRequires. This is already handled by %go_vendor_license_buildrequires. - Is the robots.txt that disallows every single crawler (User-agent: * and Disallow: /) something we want to ship in the package? That seems pretty opinionated. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2354888 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202354888%23c40 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
