https://bugzilla.redhat.com/show_bug.cgi?id=2362330 --- Comment #3 from Neal Gompa <ngompa13@xxxxxxxxx> --- Spec review: > # Without this build fails with Empty %files file {..}/debugsourcefiles.list > %global debug_package %{nil} Set "BuildArch: noarch" instead in your spec file. There's no arch-specific content in here anyway. > Summary: Includes all keys that have been used for releasing KDE software Needs a tighter summary that explains what this is. Suggestion: "Keyring of signing keys from KDE community members" > Source0: https://invent.kde.org/sysadmin/%{base_name}/-/archive/%{commit}/%{base_name}-%{shortcommit}.tar.gz DRY: "%{url}/-/archive/%{commit}/%{base_name}-%{shortcommit}.tar.gz" > install -m644 -p -D %{base_name}.asc %{buildroot}%{_datadir}/kde/%{base_name}.asc No. This should be "%{_datadir}/%{name}/" instead of "%{_datadir}/kde/". We also should install all the individual keys that make up the keyring in a subfolder. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2362330 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202362330%23c3 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
