[Bug 2352770] Review Request: python-usbsdmux - USB-SD-Mux control software and library

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2352770



--- Comment #15 from Benson Muite <benson_muite@xxxxxxxxxxxxx> ---
Almost there. Please change

BuildRequires:  systemd-rpm-macros
BuildRequires:  sed

Provides:       %{srcname} = %{version}-%{release}

Recommends:     python3-paho-mqtt

%{?python_enable_dependency_generator}

to
BuildRequires:  systemd-rpm-macros
BuildRequires:  sed

%{?python_enable_dependency_generator}

Please also change
%package -n python3-%{srcname}
Summary:        %{summary}
Requires:       systemd-udev

%description -n python3-%{srcname} %_description

to

%package -n python3-%{srcname}
Summary:        %{summary}
Requires:       systemd-udev

Provides:       %{srcname} = %{version}-%{release}

Recommends:     python3-paho-mqtt

%description -n python3-%{srcname} %_description

and finally change

%files -f %{pyproject_files}
%license COPYING

to
%files -n python3-%{srcname} -f %{pyproject_files}
%license COPYING


This will ensure the correct package is provided and the appropriate
directories are owned.

An example build:
 https://copr.fedorainfracloud.org/coprs/build/8957856


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2352770

Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202352770%23c15

-- 
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux