https://bugzilla.redhat.com/show_bug.cgi?id=2294718 --- Comment #28 from Jerry James <loganjerry@xxxxxxxxx> --- This is getting much better. We still have a handful of issues, but we're getting close. - If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. Note: License file COPYING-DOCS is not marked as %license See: https://docs.fedoraproject.org/en-US/packaging- guidelines/LicensingGuidelines/#_license_text Add this under "%files doc": %license doc/cs/COPYING-DOCS You probably should also add this, but I will leave that up to you: %doc doc/cs/README-DOCS.TXT - There is no such SPDX identifier as GFDL-1.1. See https://spdx.org/licenses/. Since doc/cs/README-DOCS.TXT says there are no invariant sections, and that version 1.1 or any later version is acceptable, I think you want GFDL-1.1-no-invariants-or-later. - I'm not convinced that the License field for the main package is complete. For example, there are files distributed under GPL-2.0-or-later: - swidget/SEditorIF.h - swidget/SUndo.{cpp,h} - swidget/SYuditInput.{cpp,h} I am unsure whether some files are included in the build or not, but there are more that have licenses other than GPL-2.0-only. For example: - bin/angles.pl (GPL-2.0-or-later) - bin/bidiclass.pl (GPL-2.0-or-later) - bin/charclass.pl (GPL-2.0-or-later) - bin/precompose1.pl (GPL-2.0-or-later) - bin/shape.pl (GPL-2.0-or-later) - mytool/hwd/strokedata.h (GPL-2.0-or-later) - mytool/uni/8859-13.TXT (some Unicode license) - mytool/uni/ISO002.TXT (MIT) - mytool/uni/viscii.txt (MIT) Finally, you've added a CC0-1.0 license to the metainfo file, so that will have to appear in the License field as well. You might want to consider distributing the metainfo file under the same GPL-2.0-only license as yudit itself to avoid that. - I had you move %configure from %prep to %build. If you wish, you can also create a %conf section and move %configure there. (Leaving it in %build is fine.) - Previously asked question that has not been answered: why is yudit.properties installed in both /etc/yudit and /usr/share/yudit/config? - Not all hardcoded pathnames have been replaced with macros. See https://docs.fedoraproject.org/en-US/packaging-guidelines/RPMMacros/#macros_installation Make the following changes: /usr/share/metainfo -> %{_metainfodir} /usr/share -> %{_datadir} -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2294718 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202294718%23c28 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
