https://bugzilla.redhat.com/show_bug.cgi?id=2325294 --- Comment #15 from Sandro <gui1ty@xxxxxxxxxxxxx> --- (In reply to Terje Rosten from comment #11) > New package ready: > > - fixed duplicate license issue > - add fzf to buildreq and req > - add a test and run it with pytest > - fixed description > - use macro in source url [!] - fixed duplicate license issue You removed `-l` from %pyproject_save_files. While this works, it will break your package should upstream accidentally remove the LICENSE file or switch to another build backend that does not automagically include it. Every package MUST have a license file. My earlier comment could have been clearer. Rule of thumb: Only remove %license from %files when using `%pyproject_save_files -l`. [x] - add fzf to buildreq and req [x] - add a test and run it with pytest That's fine if you want to do that. But you are generally not required to supply your own tests for a package. It's not what I asked for either. Though it did bring to light that `fzf` is required for being able to use `pyfzf`. In that respect, had upstream added unit tests, this would most likely have become apparent sooner. I was referring to %pyproject_check_import - a macro that will simply import every module of a package. It's sometimes referred to as a smoke test, since it doesn't test functionality, but can detect missing runtime requirements upstream forgot to specify or optional dependencies used incorrectly. [x] - fixed description [x] - use macro in source url Talking about the diff and your spec file, three more points: a. `BuildRequires: sed` is unnecessary and should be removed. The rpm package itself already requires `sed`. Thus it will always be available in the chroot without specifying it. b. You are using `sed` in %install to fix a shebang. If you need to modify any sources, please do so in %prep. Simply moving the `sed` line and fixing the path to the file should be enough. c. %check comes before %files. Please have a look at the templates: https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_example_spec_file Please address the issue marked [!] as well as points b and c. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2325294 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202325294%23c15 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
