https://bugzilla.redhat.com/show_bug.cgi?id=2354888 --- Comment #25 from Nils Philippsen <nphilipp@xxxxxxxxxx> --- (In reply to Zbigniew Jędrzejewski-Szmek from comment #23) > > # The binaries are all statically linked. > > %global debug_package %{nil} > > This is a misunderstanding. Whether binaries are statically linked is not > related to debuginfo data. The debuginfo data is missing because the build > process strips the binaries. Thus, drop those two lines and instead add > STRIP=0 to the %make_build line. > > BTW, I see 'build' and 'forgejo' are listed as targets. The 'build' target > also lists 'forgejo' as a dependency, so the second arg doesn't seem to be > needed. > > > -X \"code.gitea.io/gitea/modules/setting.CustomConf=%{_sysconfdir}/%{name}/conf/app.ini\" > > -X \"code.gitea.io/gitea/modules/setting.AppWorkPath=%{_sharedstatedir}/%{name}\" > > The nested quoting could just use '' to avoid escaping. But since those are > standarized paths that cannot contain any shell-special characters, the > quoting could just be dropped to simplify things. I think that the Makefile – with how it quotes variables passed in via the command line or environment – doesn’t lend itself well to inject global linker flags. So I’ll run the steps manually using %go* macros instead (even if it’s cumbersome). This will implicitly not pass in flags which would strip the binary and avoid make-related issues. I’ll retain quotes even if it’s not strictly necessary. > > < contrib/autocompletion/bash_autocomplete \ > > > %{name}.complete > > '>' and '<' are here used as unary operators. Adding whitespace after the > operator makes it look like a binary operator, which is misleading. Please > drop. Ahh no, I like it that way 😉. I’m used to spaces around operators, regardless of if they’re unary or binary, it makes things more readable in my eyes. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2354888 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202354888%23c25 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
