https://bugzilla.redhat.com/show_bug.cgi?id=2354888 --- Comment #23 from Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> --- > # The binaries are all statically linked. > %global debug_package %{nil} This is a misunderstanding. Whether binaries are statically linked is not related to debuginfo data. The debuginfo data is missing because the build process strips the binaries. Thus, drop those two lines and instead add STRIP=0 to the %make_build line. BTW, I see 'build' and 'forgejo' are listed as targets. The 'build' target also lists 'forgejo' as a dependency, so the second arg doesn't seem to be needed. > -X \"code.gitea.io/gitea/modules/setting.CustomConf=%{_sysconfdir}/%{name}/conf/app.ini\" > -X \"code.gitea.io/gitea/modules/setting.AppWorkPath=%{_sharedstatedir}/%{name}\" The nested quoting could just use '' to avoid escaping. But since those are standarized paths that cannot contain any shell-special characters, the quoting could just be dropped to simplify things. > < contrib/autocompletion/bash_autocomplete \ > > %{name}.complete '>' and '<' are here used as unary operators. Adding whitespace after the operator makes it look like a binary operator, which is misleading. Please drop. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2354888 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202354888%23c23 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
