https://bugzilla.redhat.com/show_bug.cgi?id=2346041 --- Comment #19 from Neal Gompa <ngompa13@xxxxxxxxx> --- Since the legal stuff seems to be squaring away, here's the spec review: > %global _debugsource_template %{nil} This is bad. We don't want debuginfo packages disabled. This is a sign that something is going wrong in the spec file elsewhere. > %define stripped_version 2409 This should be turned into a something that is generated from %{version} so that it doesn't need to be updated in two places. > Source1: p7zip.sh > Source2: p7zip.1 > Source3: 7z.sh > Source4: 7z.1 > Source5: 7za.sh > Source6: 7za.1 > Source7: 7zr.sh > Source8: 7zr.1 > Source9: 7zz.sh > Source10: 7zz.1 > Patch0: fix-compatib-with-p7zip.patch Where are these from? There's no indication of where they came from. > BuildRequires: dos2unix > BuildRequires: gcc-c++ Missing "BuildRequires: make" Cf. https://fedoraproject.org/wiki/Changes/Remove_make_from_BuildRoot > Provides: p7zip = %{version} > Provides: p7zip-full = %{version} > Obsoletes: p7zip < %{version} > Obsoletes: p7zip-full < %{version} These need to use "%{version}-%{release}", and you're missing archful Provides (ie "Provides: p7zip%{?_isa} = %{version}-%{release}"). Also, these stanzas are completely wrong, since we never had p7zip-full. Please review how the upgrade path is supposed to work to match our actual p7zip package. > Provides: p7zip-plugins = %{version} > Obsoletes: p7zip-plugins < %{version} Also these need to use "%{version}-%{release}", and you're missing archful Provides. > Provides: p7zip-doc = %{version} > Obsoletes: p7zip-doc < %{version} Also these need to use "%{version}-%{release}". > #undefine _strict_symbol_defs_build > #set_build_flags > # Inject CFLAGS > sed -i 's#^ -fPIC# -fPIC %{optflags}#' CPP/7zip/7zip_gcc.mak > sed -i 's/LFLAGS_ALL = -s/LFLAGS_ALL =/' CPP/7zip/7zip_gcc.mak This doesn't seem to be working, as evidenced by you disabling the debuginfo subpackage template. > %ifarch x86_64 %ix86 %x86_64 > #sed -i 's/$(CXX) -o $(PROGPATH)/$(CXX) -Wl,-z,noexecstack -o $(PROGPATH)/' CPP/7zip/7zip_gcc.mak > %endif Why do you have a commented out command inside of conditional? This makes it effectively no-op. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2346041 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202346041%23c19 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
