https://bugzilla.redhat.com/show_bug.cgi?id=2357266 --- Comment #25 from Bryn M. Reeves <bmr@xxxxxxxxxx> --- > Please use %{buildroot} over ${RPM_BUILD_ROOT} so that paths are consistently evaluated through the macro engine. For consistency it would be nice if the Fedora Packaging Guidelines picked a side on this. The current text reads: "There is very little value in choosing one style over the other, since they will resolve to the same values in all scenarios. You should pick a style and use it consistently throughout your packaging." https://docs.fedoraproject.org/en-US/packaging-guidelines/#_using_buildroot_and_optflags_vs_rpm_build_root_and_rpm_opt_flags The RPM Packaging Guide does express a preference (for the same reason you give), but hasn't been updated in over two years and lacks any discussion of %generate_buildrequires and other newer features: https://rpm-packaging-guide.github.io/ > This is a spec build section that runs after %prep and before %build, so please consider placing it there in the spec file too. Thanks. I was lead astray by the Python example at: https://fedoraproject.org/wiki/Changes/DynamicBuildRequires#Python Which places the %generate_buildrequires after the BuildRequires. Even reading: https://src.fedoraproject.org/rpms/pyproject-rpm-macros It's not clearly stated where these should go (other than an example under the provisional Declarative Buildsystem section) - I should have referred to the examples in: https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2357266 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202357266%23c25 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
