https://bugzilla.redhat.com/show_bug.cgi?id=2257921 --- Comment #10 from Sandro <gui1ty@xxxxxxxxxxxxx> --- Thanks for the detailed review. > You might find that it’s simpler to package a post-release snapshot of that > commit, rather than patching the license, but the status quo is OK. I actually like that idea. Though, trying to get there with forge macros _and_ Versioneer makes this more difficult than it should be. I might still do it anyway. > I tried to demonstrate this, but I could not seem to get it working. Given > that _version.py was unchanged from upstream, I also tried to avoid the > song-and-dance with git in %prep and just export > SETUPTOOLS_SCM_PRETEND_VERSION, but (unusually) I could not get that to work > either. I wonder what is different here from most other packages that use > Versioneer… That statement confused me. Does Versioneer honor SETUPTOOLS_SCM_PRETEND_VERSION? I searched through the code and didn't find any mention of it. There is an open issue requesting support for an override by environment variable: https://github.com/python-versioneer/python-versioneer/issues/199 For the rest of the discussion regarding Versioneer, I believe we had a similar debate before. Somehow, I thought using the packaged Versioneer would allow me to omit expanding on the license. But it seems I remembered wrong and I will have to add something either way. I will try to get it working using the system installed Versioneer replacing whatever upstream ships. I wish we could get a global exception not having to bother with Versioneer's license... > A zero-byte file is still importable as an empty Python module: > > python3 -c 'import medimages4tests.mri.neuro.basex' > > …and by removing the source, you have broken the import. The empty module > seems pointless, but it might still be used somewhere, and there is no good > reason to diverge from upstream here. By "broken the import" are you referring to the import statement above? Because for me `%pyproject_check_import` works either way. Your point is valid, though, and I removed that bit. I will add an `.rpmlintrc` silencing the error. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2257921 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202257921%23c10 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
