https://bugzilla.redhat.com/show_bug.cgi?id=2357266 --- Comment #22 from Bryn M. Reeves <bmr@xxxxxxxxxx> --- Thanks everyone for the helpful review comments. I have made some further updates to the spec file based on feedback and a closer reading of the Fedora Packaging Guidelines. A new upstream release, snapm-0.4.3 has been made incorporating these changes: https://github.com/snapshotmanager/snapm/releases/tag/v0.4.3 And I have updated the draft spec/SRPM: Spec URL: https://bmr.fedorapeople.org/snapm/3/snapm.spec SRPM URL: https://bmr.fedorapeople.org/snapm/3/snapm-0.4.3-1.fc43.src.rpm Changes since v2: * Dropped global sphinx_docs and made docs build unconditional * Switched to dynamic buildrequires * Dropped obsolete python_provide macro use * Deleted obsolete Requires: %{__python3} * Replaced direct install invocation with %{__install} * Replaced direct make invocation with %{make_build} * Simplified doc build and cleanup Unless anyone has any further suggestions I intend to go ahead with packaging the release this week. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2357266 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202357266%23c22 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
