https://bugzilla.redhat.com/show_bug.cgi?id=2356940 Alex Haydock <alex@xxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alex@xxxxxxxxxxxxxxxxx --- Comment #3 from Alex Haydock <alex@xxxxxxxxxxxxxxxxx> --- Hi! I tried taking a look at this package as a non-binding review. I am not a Fedora Packager yet, but as part of the pre-requisites to become one I am trying to review existing packages in the queue to get familiar with the basics and some of the philosophy behind various design decisions. I spotted a few things so far in the current SPEC: The line: ``` %global debug_package %{nil} ``` Should not be needed as the package is a `noarch` package without any ELF objects with debuginfo, so there can be no debuginfo. The `-p` flag should be used for `install` arguments to preserve timestamps, e.g.: ``` install -Dpm755 bootmac -t %{buildroot}%{_bindir}/ ``` At a package level, I'm not too familiar with the codebase here but I'm wondering if there's a particular reason why the `bootmac-wifi.rules` from upstream have been included, but the `bootmac-bluetooth.rules` equivalent for Bluetooth has not? -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2356940 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202356940%23c3 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
