https://bugzilla.redhat.com/show_bug.cgi?id=2353989 Fabio Valentini <decathorpe@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ Status|ASSIGNED |POST --- Comment #7 from Fabio Valentini <decathorpe@xxxxxxxxx> --- Thank you, looks good to me now! You can automate the things you needed to change from the defaults with a rust2rpm.toml config file like this, if you haven't already: ``` [package] cargo-toml-patch-comments = [ "LICENSE not in sources fixed upstream: https://github.com/gyscos/cursive/pull/818";, ] license-files = ["LICENSE"] [[package.extra-sources]] number = 2 file = "https://github.com/gyscos/cursive/raw/main/LICENSE"; comments = ["Missing LICENSE file is fixed upstream: https://github.com/gyscos/cursive/pull/814";] [scripts] prep.post = ["cp -pav %{SOURCE2} ."] ``` This also prevents the "no license files detected" error without passing the "-I" flag to rust2rpm. === Package was generated with rust2rpm, simplifying the review. ✅ package contains only permissible content ✅ package builds and installs without errors on rawhide ✅ test suite is run and all unit tests pass ✅ latest version of the crate is packaged ✅ license matches upstream specification and is acceptable for Fedora 🫤 license file is included with %license in %files (included manually from upstream for now, will be resolved with the next version) ✅ package complies with Rust Packaging Guidelines Package APPROVED. === Recommended post-import rust-sig tasks: - set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter (*NOT* pre-release filter): alpha;beta;rc;pre distro: Fedora Package: rust-$crate - set bugzilla assignee overrides to @rust-sig (optional) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2353989 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202353989%23c7 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
