https://bugzilla.redhat.com/show_bug.cgi?id=2360799 --- Comment #2 from Mateus Rodrigues Costa <mateusrodcosta@xxxxxxxxx> --- Hi, so here's a bunch of notes that I believe might help in the review process. I looked into adopting and updating the mozilla-fira-fonts package and it turned out a bit more complex than I expected, with even the chance of me having to port from older macros to newer ones. So I though that since I was going to sumbit FiraGO eventually anyway, why not package it first? So, for FiraGO I had two ways of getting the fonts: 1) Grabbing from Github at https://github.com/bBoxType/FiraGO, the problem with this approach is that there is a 1.000 tag but not a 1.001 tags, menaing I would need to clone a specific commit of the repo 2) Download from the foundry at https://bboxtype.com/typefaces/FiraGO/ via https://bboxtype.com/downloads/FiraGO/Download_Folder_FiraGO_1001.zip, however the OFL license file isn't included and has to be downloaded separately (https://bboxtype.com/downloads/FiraGO/OFL.txt) I chose approach 2. I based the spec on the `spectemplate-fonts-0-simple.spec` template. But I had issues with the following macros: %global foundry - People on the Fedora Devel Matrix room said that this foundry wasn't a "registered foundry" or something along those lines, so apaprently I don't need to fill this %global fontlicenses - Couldn't get the package build to accept the downloaded OFL.txt file %global fontdocs - I was planning to add the technical documentation PDFs here, but either I had uses escaping spaces or it said the file didn't exist, so eventually I gave up %global fontdocsex - it apparently depends on the previous two, so removed as well I did forget to look into fontconfig priority though. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2360799 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202360799%23c2 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
