https://bugzilla.redhat.com/show_bug.cgi?id=2358968 Fabio Valentini <decathorpe@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|nobody@xxxxxxxxxxxxxxxxx |decathorpe@xxxxxxxxx Flags| |fedora-review? CC| |decathorpe@xxxxxxxxx Status|NEW |ASSIGNED --- Comment #8 from Fabio Valentini <decathorpe@xxxxxxxxx> --- Some minor issues: > # Broken test because tests.rs is not in crate > sed -i '/#\[cfg(test)\]/,/mod tests/d' src/lex/mod.rs > sed -i '/#\[cfg(test)\]/,/mod tests/d' src/lib.rs > sed -i '/#\[cfg(test)\]/,/mod tests/d' src/parse/mod.rs Would be great if this could be resolved upstream. Including one file shouldn't hurt and would make our lives much easier. (i.e. if tests *compile* you can skip the ones that can't *run*, but if they don't *compile* you need to hack stuff ...) And the README.md file apparently has CRLF line endings, would be good to have that fixed upstream too (for downstream, running "dos2unix --keep-timestamps" or whatever the flag is called should do). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2358968 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202358968%23c8 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
