https://bugzilla.redhat.com/show_bug.cgi?id=2360112 --- Comment #3 from Neal Gompa <ngompa13@xxxxxxxxx> --- Spec review: > %global upstream_tag 1.0.0rc You might want to consider breaking it up like so: %global baseversion 1.0.0 %global prerel rc %global upstream_tag %{baseversion}%{?prerel} Version: %{baseversion}%{?prerel:~%{prerel}} > Source: https://github.com/google/ngx_brotli/archive/refs/tags/v%{upstream_tag}.tar.gz This should be "%{url}/archive/v%{upstream_tag}/ngx_brotli-%{upstream_tag}.tar.gz > BuildRequires: libbrotli I took a look at this, and it looks like you need to unbundle brotli, as it's currently not using libbrotli at all. Once you fix that, then you should be able to use "brotli-devel" as a build dependency. I recommend adjusting the "config" script files to locate brotli through pkgconfig. You can see an example of how to do this in the nginx naxsi module code. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2360112 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202360112%23c3 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
