https://bugzilla.redhat.com/show_bug.cgi?id=2360119 Fabio Valentini <decathorpe@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |decathorpe@xxxxxxxxx Assignee|nobody@xxxxxxxxxxxxxxxxx |decathorpe@xxxxxxxxx Flags| |fedora-review? --- Comment #6 from Fabio Valentini <decathorpe@xxxxxxxxx> --- Thanks - this looks more straightforward than half a dozen separate packages. Some quick notes before dependencies are ready: - Since you're no longer building from the crates on crates.io, you *must* drop the "rust-" prefix for the package name: https://docs.fedoraproject.org/en-US/packaging-guidelines/Rust/#_package_naming_3 - Please use the documented patterns for Version / Source URL / %autosetup etc. for packaging git snapshots: https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/#_commit_revision https://docs.fedoraproject.org/en-US/packaging-guidelines/Versioning/#_snapshots - Don't glob-own *everything* in %{_bindir}. https://docs.fedoraproject.org/en-US/packaging-guidelines/#_explicit_lists - "%{_datadir}/%{name}/%{efiarch}/*.efi" causes the folders to be unowned. You either need to own "%{_datadir}/%{name}/" entirely, or list both *.efi files *and* the directory structure as %dir entries separately. https://docs.fedoraproject.org/en-US/packaging-guidelines/UnownedDirectories/ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2360119 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202360119%23c6 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
