https://bugzilla.redhat.com/show_bug.cgi?id=2358883 Cole Robinson <crobinso@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(osteffen@redhat.c |needinfo?(decathorpe@gmail. |om) |com) CC| |decathorpe@xxxxxxxxx --- Comment #8 from Cole Robinson <crobinso@xxxxxxxxxx> --- This looks ok to me. One small tweak: add a comment before the `Patch:` documenting what changed (the rust-endian-num adjustment) + spec matches `rust2rpm bitfield-struct@0.7` output, with `Name:` change and metadata tweak + Builds on rawhide + Installs on rawhide + content looks fine But I've never reviewed a rust compat crate before. @decathorpe@xxxxxxxxx can you double check this for me? Is there anything I'm missing re: rust compat packages? -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2358883 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202358883%23c8 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
