[Bug 2305079] Review Request: clash-meta - A rule based network proxy tool. (aka mihomo)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2305079



--- Comment #2 from U2FsdGVkX1@xxxxxxxxx ---
1. You can remove the period at the end of the summary.
https://docs.fedoraproject.org/en-US/packaging-guidelines/#:~:text=Do%20not%20end%20the%20summary%20with%20a%20period.

2. The file /usr/share/doc/clash-meta/docs/logo.png has executable permissions,
which could pose a security risk:
-rwxr-xr-x. 1 mockbuild mock 15K Mar 28 11:08 logo.png

3. Is the license correctly specified? It currently points to
vendor/modules.txt.

4. It seems the application does not read configuration from /etc/clash-meta by
default. If it is intended to read from there, perhaps you should copy
docs/config.yaml to /etc/clash-meta, similar to how Caddy does it.


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2305079

Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202305079%23c2

-- 
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux