https://bugzilla.redhat.com/show_bug.cgi?id=2358822 Miroslav Suchý <msuchy@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |msuchy@xxxxxxxxxx Blocks| |177841 (FE-NEEDSPONSOR) --- Comment #8 from Miroslav Suchý <msuchy@xxxxxxxxxx> --- > cp %{SOURCE1} %{buildroot}%{_datadir} You should preserve the original timestamp. See https://docs.fedoraproject.org/en-US/packaging-guidelines/#_timestamps I recommend using `cp -a` or `cp -p`. The selinux part should be improved. You do not have `Requires` and you do not relabel files that changed context. I wanted to point you to relevant documentation, but to my surprise there is none. But you can get inspiration from other packages: https://src.fedoraproject.org/rpms/incus/blob/rawhide/f/incus.spec https://src.fedoraproject.org/rpms/dnsconfd/blob/rawhide/f/dnsconfd.spec (randomly selected) As you are not packager yet, you should follow https://docs.fedoraproject.org/en-US/package-maintainers/Package_Review_Process/#review_process and your first review should block FE-NEEDSPONSOR tracking bug. (I done this for you now). Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2358822 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202358822%23c8 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
