https://bugzilla.redhat.com/show_bug.cgi?id=2359521 Petr Pisar <ppisar@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #2 from Petr Pisar <ppisar@xxxxxxxxxx> --- Source0 and URL addresses are Ok. Source0 archive (SHA-512: cd15bdbec2a71e83ddbdc904908963cc646448b866329ce2564d7d66700dc03dc9d47a10533f6cdb1b11ca12f9042764821d66aebd5a2e64570016d9d8640a55) is original. Ok. Summary verified from lib/Darwin/InitObjC.pm. Ok. Description verified from lib/Darwin/InitObjC.pm. Ok. License verified in lib/Darwin/InitObjC.pm, LICENSE, META.json. Ok. No XS code, noarch BuildArch is Ok. FIX: Do not build-require 'perl(DynaLoader)'. It's not used at build time on Linux. All tests pass. Ok. $ rpmlint perl-Darwin-InitObjC.spec ../SRPMS/perl-Darwin-InitObjC-0.001-1.fc43.src.rpm ../RPMS/noarch/perl-Darwin-InitObjC-0.001-1.fc43.noarch.rpm ======================================== rpmlint session starts ======================================= rpmlint: 2.7.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 3 perl-Darwin-InitObjC.noarch: E: incorrect-fsf-address /usr/share/licenses/perl-Darwin-InitObjC/LICENSE === 2 packages and 1 specfiles checked; 1 errors, 0 warnings, 6 filtered, 1 badness; has taken 0.3 s == rpmlint is Ok. $ rpm -q -lv -p ../RPMS/noarch/perl-Darwin-InitObjC-0.001-1.fc43.noarch.rpm drwxr-xr-x 2 root root 0 Apr 11 02:00 /usr/share/doc/perl-Darwin-InitObjC -rw-r--r-- 1 root root 89 Apr 5 08:26 /usr/share/doc/perl-Darwin-InitObjC/Changes drwxr-xr-x 2 root root 0 Apr 11 02:00 /usr/share/licenses/perl-Darwin-InitObjC -rw-r--r-- 1 root root 19786 Apr 5 08:26 /usr/share/licenses/perl-Darwin-InitObjC/LICENSE -rw-r--r-- 1 root root 1461 Apr 11 02:00 /usr/share/man/man3/Darwin::InitObjC.3pm.gz drwxr-xr-x 2 root root 0 Apr 11 02:00 /usr/share/perl5/vendor_perl/Darwin -rw-r--r-- 1 root root 1569 Apr 5 08:26 /usr/share/perl5/vendor_perl/Darwin/InitObjC.pm File layout and permissions are Ok. $ rpm -q --requires -p ../RPMS/noarch/perl-Darwin-InitObjC-0.001-1.fc43.noarch.rpm | sort -f | uniq -c 1 perl(Config) 1 perl(strict) 1 perl(warnings) 1 perl-libs 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsZstd) <= 5.4.18-1 TODO: Run-require perl(DynaLoader) if you think the init() subroutine is a public function (lib/Darwin/InitObjC.pm:10). $ rpm -q --provides -p ../RPMS/noarch/perl-Darwin-InitObjC-0.001-1.fc43.noarch.rpm | sort -f | uniq -c 1 perl(Darwin::InitObjC) = 0.001 1 perl-Darwin-InitObjC = 0.001-1.fc43 Binary Provides are Ok. $ resolvedeps rawhide ../RPMS/noarch/perl-Darwin-InitObjC-0.001-1.fc43.noarch.rpm Binary dependencies are resolvable. Ok. The package builds in Fedora 43 (https://koji.fedoraproject.org/koji/taskinfo?taskID=131558205). Ok. Otherwise, the package is in line with Fedora and Perl packaging guidelines. Please correct the FIX item and consider fixing the TODO item before building this package. This package is APPROVED. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2359521 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202359521%23c2 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
