https://bugzilla.redhat.com/show_bug.cgi?id=2358822 Pavol Sloboda <psloboda@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(psloboda@redhat.c |needinfo?(ljavorsk@redhat.c |om) |om) --- Comment #5 from Pavol Sloboda <psloboda@xxxxxxxxxx> --- Spec URL: https://download.copr.fedorainfracloud.org/results/psloboda/credcheck/fedora-rawhide-x86_64/08904865-credcheck/credcheck.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/psloboda/credcheck/fedora-rawhide-x86_64/08904865-credcheck/credcheck-3.0-1.fc43.src.rpm > This can be achieved using the `postgresql-test-rpm-macros` subpackage [1] similarly e.g., package postgis is testing itself [2] (look for the "runselftest"). I have looked into the package and tried the provided method but the credcheck package does not provide the make check directive an the regress tests needed to run that directive, only the make installcheck directive which can be ran only after the installation finishes. Implementation of the regress tests would require the rewrite of the test suite and another patch to the makefile to accommodate them. > Question: Is there a reason why you're using conditions like `%if %{deny_easy_pass} == 1` instead of `%if %{without deny_easy_pass}` (%bcond_without deny_easy_pass)? Thank you, I have looked into it and changed the conditions to more suitable ones. As for the other tips and comments, I have changed the spec file to accommodate them. Thank you for the tips. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2358822 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202358822%23c5 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
