https://bugzilla.redhat.com/show_bug.cgi?id=2305346 --- Comment #17 from Michal Schorm <mschorm@xxxxxxxxxx> --- I did a major rework. Until now, the code was derived from CentOS Stream 10 branch, which was based on Fedora content. Now I've rebased all the relevant changes from the CentOS Stream 10 branch onto the current Fedora Rawhide branch. So now it both contains the latest Fedora changes and the code is a natural evolution of the existing Fedora package - mysql8.0 The current links are: Spec URL: https://download.copr.fedorainfracloud.org/results/mschorm/mysql8.4/fedora-rawhide-x86_64/08898139-mysql8.4/mysql8.4.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/mschorm/mysql8.4/fedora-rawhide-x86_64/08898139-mysql8.4/mysql8.4-8.4.4-1.fc43.src.rpm COPR fedora-review report: https://download.copr.fedorainfracloud.org/results/mschorm/mysql8.4/fedora-rawhide-x86_64/08898139-mysql8.4/fedora-review/review.txt Git: https://src.fedoraproject.org/fork/mschorm/rpms/mysql8.0/commits/mysql8.4_package_review -- I've tried to fix the "%global instead of %define". I managed to fix one occurrence: https://src.fedoraproject.org/fork/mschorm/rpms/mysql8.0/c/ffb3296?branch=mysql8.4_package_review However when I changed the other instances, the code broke. The other instances use the %define for function calls, processing arguments, and so on. They are responsible for proper generation of virtual Provides and Conflicts. When I tried to use %global there, the generated virtual relationship broke, making the sub-packages conflicting with every other, leaving the package FTI. I will try to revisit it in the future, but at this moment I wasn't able to fix the whole problem. I hope this is effort is acceptable for the review to pass. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2305346 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202305346%23c17 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
