https://bugzilla.redhat.com/show_bug.cgi?id=2354972 --- Comment #8 from Sandro <gui1ty@xxxxxxxxxxxxx> --- Thanks for doing the review. I have an update regarding the included third party stuff. I turns out CLI11.hpp is included in converter/converter.cpp, which is the source for units_convert - an app provided for doing standalone unit conversion, which I also intent to include in the binary RPM. I updated the spec file to reflect on the situation regarding the shipped third party sources. I also removed the shipped CLI11.hpp in favor of the headers from cli11-devel. CLI11 is a header only library. Now I wonder if "transformed in some way (for example, by compilation)" applies to header files. If not, unbundling the header file would not strictly be required. But with this change, this becomes a question of curiosity. For quick reference, upstream has it documented in https://github.com/LLNL/units/blob/main/CONTRIBUTORS.md (a bit of a misnomer). Spec URL: https://gui1ty.fedorapeople.org/review/units-llnl.spec SRPM URL: https://gui1ty.fedorapeople.org/review/units-llnl-0.13.0-2.fc43.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2354972 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202354972%23c8 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
