https://bugzilla.redhat.com/show_bug.cgi?id=2332914 --- Comment #15 from Fabio Valentini <decathorpe@xxxxxxxxx> --- Taking another look now, thanks for the update. Will post review in a separate comment to avoid wall-of-text :) > Ah this is definitely a casualty of piecing together various tutorials from around the web to make this one SPEC. Your 16-space style makes a lot of sense to me so I've adopted that now. Yeah there's sadly a lot of outdated or obsolete tutorials and docs for RPM packaging on the web :( We're trying to keep at least the official docs up-to-date, but we're not always succeeding there, either. > Fixed. I see you've used %{version} there where the docs page uses %{gittag} so I guess it relies on the assumption that the upstream project will continue to use release tags that match version numbers but if they ever stop then I suppose it'll be obvious quite quickly. Yeah, when the format of the git tags matches the version string, you can just use the version string directly. Some projects prefix their release tags with a "v" character, then you can just use "v%{version}" in the URL. No need to do something more complicated. :) > Sounds like that [checksumming upstream sources] is all provided for when a package is imported into Fedora proper. Yes, the checksum is determined *once* from the copy of the source tarball that you upload to Fedora servers, and then all subsequent uses of that tarball need to match that checksum. > Is there a process for documenting where an upstream dependency can't be satisfied in the Fedora package? > Alternatively I could just make it clear this is the case when I update the upstream docs after the package is imported into Fedora. In this case I would just put a comment in the spec file that this optional dependency is not available from the Fedora repositories. Documenting it upstream might also be nice, i.e. something like "zsync is only available from third-party repositories, you will need to enable RPMFusion repos for your Fedora version and install zsync from there, if you want it". -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2332914 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202332914%23c15 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
