https://bugzilla.redhat.com/show_bug.cgi?id=1187030 --- Comment #64 from Benson Muite <benson_muite@xxxxxxxxxxxxx> --- (In reply to Fedora Review Service from comment #62) > Created attachment 2084361 [details] > The .spec file difference from Copr build 8471129 to 8887945 (In reply to Joachim Frieben from comment #61) > (In reply to Benson Muite from comment #60) > Regarding comment > a) it is correct that %ldconfig_scriptlets is no longer needed on (recent) > Fedora releases. However, it is still needed when the package is built for > EPEL 7. I have noticed that EPEL 7 is EOL but the build options for new > projects on COPR do still include EPEL 7. On the other hand, the previous > successful build completed in January 2025 now fails when built for EPEL 7 > which might be due to its EOL. I therefore had to exclude EPEL 7 from the > build targets. For the time being I have added a switch in order to skip > %ldconfig_scriptlets on releases where it is not needed. It might get simply > removed in the near future, Thanks. > b) I think the relevant licenses are GPL-3.0-only and LGPL-3.0-only. I have > changed the license entry accordingly and included both license files. The > are some auxiliary files like giza/build/install-sh subject to other > licenses but adding those, too, might lead a bit far, and Thanks. > c) this issue had already been addressed in comment #48) to which I had > replied in comment #49). There is no activity on this. Perhaps until it is resolved, co-own the directory. If it is an error in the review tool, that is different. Final suggestion, directories such as %{_includedir} contain files from different packages, possibilities of collisions are high. It is preferable not to glob everythin so that if there are changes, these can be accounted for. Would suggest changing %files %doc AUTHORS ChangeLog LATEST.md NEWS README.md %license COPYING COPYING.LESSER %if 0%{?rhel} && 0%{?rhel} < 8 %{_libdir}/*.so.%{so_version}* %else %{_libdir}/*.so.%{so_version}{,.*} %endif %files devel %{_fmoddir}/* %{_includedir}/* %{_libdir}/*.so %{_libdir}/pkgconfig/* to %files %doc AUTHORS ChangeLog LATEST.md NEWS README.md %license COPYING COPYING.LESSER %if 0%{?rhel} && 0%{?rhel} < 8 %{_libdir}/libcpgplot.so.%{so_version}* %{_libdir}/libgiza.so.%{so_version}* %{_libdir}/libpgplot.so.%{so_version}* %else %{_libdir}/libcpgplot.so.%{so_version}{,.*} %{_libdir}/libgiza.so.%{so_version}{,.*} %{_libdir}/libpgplot.so.%{so_version}{,.*} %endif %files devel %{_fmoddir}/giza.mod %{_includedir}/cgplot.h %{_includedir}/giza-Fortran.F90 %{_includedir}/giza.h %{_includedir}/giza-shared.h %{_includedir}/giza-version.h %{_libdir}/libcpgplot.so %{_libdir}/libgiza.so %{_libdir}/libpgplot.so %{_libdir}/pkgconfig/cgplot.pc %{_libdir}/pkgconfig/giza.pc %{_libdir}/pkgconfig/pgplot.pc > > Spec URL: > https://download.copr.fedorainfracloud.org/results/frieben/giza/fedora- > rawhide-x86_64/08887848-giza/giza.spec > SRPM URL: > https://download.copr.fedorainfracloud.org/results/frieben/giza/fedora- > rawhide-x86_64/08887848-giza/giza-1.5.0-2.fc43.src.rpm -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=1187030 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%201187030%23c64 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
