https://bugzilla.redhat.com/show_bug.cgi?id=2358606 --- Comment #5 from Ben Beasley <code@xxxxxxxxxxxxxxxxxx> --- Thank you for the review! Looking at https://github.com/unicode-org/icu4x, all of the include patterns are inherited from the workspace, so it looks like upstream means to ship test and benchmark data in general. It’s a little weird that they bother with the placeholder “trick” here when the git repo is already in the hundreds of megabytes, and other crates like icu_segmenter have several megabytes of test data, but I suppose weird is OK. It might make sense for me to omit the benchmark data as a downstream patch to Cargo.toml. It’s not huge, but nothing in Fedora will use it. I’ll investigate that after importing. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2358606 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202358606%23c5 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
