https://bugzilla.redhat.com/show_bug.cgi?id=2262694 --- Comment #60 from Luya Tshimbalanga <luya_tfz@xxxxxxxxxxxxxxxx> --- (In reply to Zbigniew Jędrzejewski-Szmek from comment #58) > > %bcond viewer 0 # Graphical viewer (enabled by default) > The comment seems confused. Fixed. > > > %{_libdir}/libMaterialX*.so.* > The packaging guidelines say > (https://docs.fedoraproject.org/en-US/packaging-guidelines/ > #_listing_shared_library_files): > > Shared libraries installed directly into %{_libdir} SHOULD NOT be listed in the > > %files section of the spec by using a glob in a way that conceals important > > parts of the file name (e.g. libfoo.so*) Fixed with this line: "%{_libdir}/libMaterialX*.so.{1,%{version}}" Before simplification, the old spec version had the following: " %{_libdir}/libMaterialXCore.so.{1,%{version}} %{_libdir}/libMaterialXFormat.so.{1,%{version}} %{_libdir}/libMaterialXGen{,Glsl,Mdl,Msl,Osl,Shader}.so.{1,%{version}} %{_libdir}/libMaterialXRender{,Glsl,Hw,Osl}.so.{1,%{version}} " > > In https://bugzilla.redhat.com/show_bug.cgi?id=2262694#c45 Ben noticed > that bundled libraries are not handled properly and gave nanogui as an > example. > But https://bugzilla.redhat.com/show_bug.cgi?id=2262694#c41 lists many more > bundled libraries. They need to be handled too. And please note that > "handled properly" means that ideally the system version is used. Re-include the line: "Provides: bundled(nanogui) = 0.2.0^20221102gitf5020e2" Currently, upstream cmake requires git submodule for nanogui hence left disabled until a proper fix occurs. > At least glfw and catch are packaged. Fixed with the following: "BuildRequires: pkgconfig(catch2) BuildRequires: pkgconfig(glfw3)" > One more thing: the Summary says "open standard". That is rather misleading. > A package that is described as a standard would normally be expected to > contain > the text of the standard or something like that. But it seems to provide > a library that implements it or something like that, I didn't actualy look. The summary is updated with the following line: "Vendor-neutral specification for 3D material interchange" Here is the updated SPEC: https://download.copr.fedorainfracloud.org/results/@designsuite/blender/fedora-rawhide-x86_64/08882889-materialx/materialx.spec SRPM: https://download.copr.fedorainfracloud.org/results/@designsuite/blender/fedora-rawhide-x86_64/08882889-materialx/materialx-1.39.3-1.fc43.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2262694 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202262694%23c60 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
