https://bugzilla.redhat.com/show_bug.cgi?id=2352694 Ben Beasley <code@xxxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #11 from Ben Beasley <code@xxxxxxxxxxxxxxxxxx> --- Here is the diff from the original submission: $ diff -Naur ../srpm-unpacked/digdoc.spec 2352694-digdoc/srpm-unpacked/digdoc.spec --- ../srpm-unpacked/digdoc.spec 2025-03-15 20:00:00.000000000 -0400 +++ 2352694-digdoc/srpm-unpacked/digdoc.spec 2025-04-08 20:00:00.000000000 -0400 @@ -1,28 +1,18 @@ -## START: Set by rpmautospec -## (rpmautospec version 0.7.3) -## RPMAUTOSPEC: autorelease, autochangelog -%define autorelease(e:s:pb:n) %{?-p:0.}%{lua: - release_number = 1; - base_release_number = tonumber(rpm.expand("%{?-b*}%{!?-b:1}")); - print(release_number + base_release_number - 1); -}%{?-e:.%{-e*}}%{?-s:.%{-s*}}%{!?-n:%{?dist}} -## END: Set by rpmautospec - Name: digdoc -Version: 0.0.1 +Version: 0.0.2 Release: %autorelease Summary: A DNS-over-CoAP client License: MIT URL: https://github.com/dig-doc/digdoc Source: %{url}/archive/v%{version}/digdoc-%{version}.tar.gz -Patch: install.patch BuildRequires: cmake BuildRequires: gcc BuildRequires: libcoap-devel BuildRequires: ldns-devel - +# Documentation dependencies +BuildRequires: help2man %description digdoc is a lightweight command-line tool written in C that acts as a @@ -37,22 +27,23 @@ %build %cmake %cmake_build - +# Build documentation +help2man --version-string='%{version}' --no-discard-stderr --no-info --name=digdoc --output=digdoc.1 %{_builddir}/digdoc-%{version}/%{__cmake_builddir}/digdoc %install %cmake_install +mkdir -p %{buildroot}/%{_mandir}/man1 +install digdoc.1 %{buildroot}/%{_mandir}/man1/digdoc.1 %check - +# Tests need internet access +# https://github.com/dig-doc/digdoc/issues/4 %files %license LICENSE %doc README.md %{_bindir}/digdoc - +%{_mandir}/man1/digdoc.1* %changelog -## START: Generated by rpmautospec -* Sun Mar 16 2025 John Doe <packager@xxxxxxxxxxx> - 0.0.1-1 -- Uncommitted changes -## END: Generated by rpmautospec +%autochangelog All feedback from the original review was handled; otherwise, the review template still applies. The generated man page has useful and usable content. The heading is a little weird: NAME digdoc - digdoc This would be improved by changing --name=digdoc to --name='%{summary}` in the help2man invocation. The patch was upstreamed. Nothing else in the new upstream release appears to require packaging changes. Release 0.0.2 does support for testing with a local server. However, running these downstream would at least require packaging https://github.com/anr-bmbf-pivot/aiodnsprox/ and adapting testing/test.sh not to install it into a virtualenv. It then still might not work, because "local" tests that require a working DNS configuration still don’t work in mock. Therefore, this is a possibility for future investigation, but it doesn’t need to block the review. The package is APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2352694 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202352694%23c11 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
