https://bugzilla.redhat.com/show_bug.cgi?id=2262694 Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |zbyszek@xxxxxxxxx --- Comment #58 from Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> --- > %bcond viewer 0 # Graphical viewer (enabled by default) The comment seems confused. > %{_libdir}/libMaterialX*.so.* The packaging guidelines say (https://docs.fedoraproject.org/en-US/packaging-guidelines/#_listing_shared_library_files): > Shared libraries installed directly into %{_libdir} SHOULD NOT be listed in the > %files section of the spec by using a glob in a way that conceals important > parts of the file name (e.g. libfoo.so*) In https://bugzilla.redhat.com/show_bug.cgi?id=2262694#c45 Ben noticed that bundled libraries are not handled properly and gave nanogui as an example. But https://bugzilla.redhat.com/show_bug.cgi?id=2262694#c41 lists many more bundled libraries. They need to be handled too. And please note that "handled properly" means that ideally the system version is used. At least glfw and catch are packaged. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2262694 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202262694%23c58 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
