[Bug 2357907] Review Request: rust-ucs2 - UCS-2 decoding and encoding functions

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2357907



--- Comment #7 from Fabio Valentini <decathorpe@xxxxxxxxx> ---
The package looks good now, thanks.

> It's about having the packages available in fedora for development.

That's a noble goal, but not really something that rust-*devel packages are
meant to support.
If you can make it work for yourself, that's fine, but it's not generally
something that is expected to work.

> It's mostly testing efi apps.  The one which might be interesting
> beyond that is netboot.efi.  A challenge on the way to package that
> is that right now there seems to be no way to tell rust2rpm that
> something should be compiled for target $(arch)-unknown-uefi.

This probably will always require some manual work to tell cargo how to compile
things ... I'm not sure if there's even *any* existing packages in Fedora that
compile for "non-native" targets like that. Though it should be possible by
replacing `%cargo_build` with the call to `cargo` and passing all necessary
arguments.

===

Package was generated with rust2rpm, simplifying the review.

✅ package contains only permissible content
✅ package builds and installs without errors on rawhide
✅ test suite is run and all unit tests pass
✅ latest version of the crate is packaged
✅ license matches upstream specification and is acceptable for Fedora
✅ license file is included with %license in %files
✅ package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter (*NOT* pre-release filter): alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- set bugzilla assignee overrides to @rust-sig (optional)


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2357907

Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202357907%23c7

-- 
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux