https://bugzilla.redhat.com/show_bug.cgi?id=2357906 Fabio Valentini <decathorpe@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |decathorpe@xxxxxxxxx Flags| |fedora-review? Assignee|nobody@xxxxxxxxxxxxxxxxx |decathorpe@xxxxxxxxx Status|NEW |ASSIGNED --- Comment #5 from Fabio Valentini <decathorpe@xxxxxxxxx> --- There's a version 2.2.1 out now, please update. > BuildRequires: crate(bytemuck/default) > BuildRequires: crate(bytemuck/derive) These should be necessary, even even then, it would be wrong to depend on crates without specifying which *version* you need. Which is why listing BuildRequires for Rust crates manually like this is a MUST NOT. :) https://docs.fedoraproject.org/en-US/packaging-guidelines/Rust/#_dynamically_generated_buildrequires_for_crate_dependencies Did you add this to be able to compile / run all tests without errors? In that case, you can add `-f bytemuck` (or possibly even `-f bytemuck,serde` to the `%cargo_generate_buildrequires`, `%cargo_build`, `%cargo_install`, and `%cargo_test` macros, which should have the desired effect. You can cause rust2rpm to do this for you permanently with this rust2rpm.toml config file: ``` [features] enable = [ "bytemuck", "serde", ] ``` Additionally, when updating the spec file for these changes, use rpmautospec. It should be the default for all new Fedora packages. Not using it for Rust packages causes a lot of manual work on crate updates (preserving %changelog entries after re-running rust2rpm, etc.). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2357906 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202357906%23c5 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
