https://bugzilla.redhat.com/show_bug.cgi?id=2351398 Jerry James <loganjerry@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #22 from Jerry James <loganjerry@xxxxxxxxx> --- That looks pretty good. Just a couple more items. To require an architecture-specific package from a noarch package, just omit "%{?_isa}". In this case, the workrave-cinnamon package would have these lines: Requires: %{name} = %{version}-%{release} BuildArch: noarch In "%files mate", there are two lines: %{_datadir}/mate-panel/ui %{_datadir}/mate-panel/ui/workrave-menu.xml The first includes the entire ui directory, including workrave-menu.xml, so rpmbuild now warns that workrave-menu.xml is listed twice. You should either remove the second line, or add %dir to the first line. These are both very simple changes that I trust you to make when you import the package. This package is APPROVED. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2351398 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202351398%23c22 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
