https://bugzilla.redhat.com/show_bug.cgi?id=2351398 --- Comment #19 from wojnilowicz <lukasz.wojnilowicz@xxxxxxxxx> --- Thanks for giving the explanations on how to fix the issues. (In reply to Jerry James from comment #17) > Package Review > ============== > > Legend: > [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated > > Issues: > ======= > I think the License field is incomplete. > - libs/config/include/config/IConfiguratorListener.hh is GPL-2.0-or-later. > You > might want to tell upstream that some text rewriter mangled the license > text. > All instances of "ion" have been converted to "or", resulting in the > license > being offered by the "Free Software Foundator", and you can use, "at your > optor", "any later versor". :-) > - ui/app/toolkits/gtkmm/platforms/unix/gtktrayicon.{c,h} are > LGPL-2.1-or-later > - > ui/app/toolkits/gtkmm/platforms/unix/protocols/wlr-layer-shell-unstable-v1. > xml > is HPND Done and reported at https://github.com/rcaelers/workrave/issues/610. > The directory /usr/share/mate-panel/ui is not owned by any package. The > mate-panel package owns /usr/share/mate-panel, but not the ui subdirectory. Done. > The workrave-mate package installs %{_libdir}/mate-applets/workrave-applet, > but does not have "Requires: mate-applets", which is the package that owns > the > %{_libdir}/mate-applets directory. Done. > The workrave-cinnamon package contains no binary files. Should it be noarch? If you know how to do it, because I don't know how to require an arch package (cinnamon in this case) from a noarch package. > The workrave-cinnamon package owns %{_datadir}/cinnamon and > %{_datadir}/cinnamon/applets, but shouldn't, since those directories are > owned > by the cinnamon package, which workrave-cinnamon Requires. Done. > The workrave-gnome package owns %{_datadir}/gnome-shell and > %{_datadir}/gnome-shell/extensions, but shouldn't, since those directories > are > owned by the gnome-shell package, which workrave-gnome Requires. Done. > There is no comment justifying the patch. This is a SHOULD item, not a MUST, > so I will not insist on it. I added the comment. > Please consider making a noarch package, required by the main package, to > contain the contents of %{_datadir}. This is another SHOULD item, so I will > not insist on it either. Done. [fedora-review-service-build] -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2351398 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202351398%23c19 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
