https://bugzilla.redhat.com/show_bug.cgi?id=2346427 Chris Adams <linux@xxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(linux@xxxxxxxxxxx | |) | --- Comment #6 from Chris Adams <linux@xxxxxxxxxxx> --- I'll change the sed to perl (should have done that to start). The idea to require coreutils seems like it could be a little over-requires... how %{_fixperms} is implemented is pretty opaque (and rpm itself already requires coreutils). Checking the current perl SRPMs, there are a whole lot that use %{_fixperms} but don't BuildRequire coreutils. The %{_fixperms} macro could change, or call a tool not in coreutils, and there'd be a lot of extra BuildRequires. I'll add it (I also see a lot of perl SRPMs that do BuildRequire it, about half), but I'm wondering if maybe that shouldn't be the norm; just expect that the package that provides the macro also BuildRequires anything needed to implement the macro. Spec URL: https://fedorapeople.org/~cmadams/perl-X-Tiny/perl-X-Tiny.spec SRPM URL: https://fedorapeople.org/~cmadams/perl-X-Tiny/perl-X-Tiny-0.22-3.fc41.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2346427 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202346427%23c6 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
