https://bugzilla.redhat.com/show_bug.cgi?id=2356982 Tobias <t-fedora@xxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(t-fedora@xxxxxxxx | |) | --- Comment #3 from Tobias <t-fedora@xxxxxxxx> --- thank you, appreciating your thorough review! > - Consider using rpmautospec (%autorelease and %autochangelog) I'm not particularly fond of those for my packages. > - If not using rpmautospec, you need to update `Release: 1%{?dist}` > - (Note that fedora-review-service failed to provide you a review template > because of the missing %{?dist} ) argh, thanks. fixed. > - License: is missing "LicenseRef-Fedora-Public-Domain" (librcksum) added. > - %check is silently ignoring the exit of ./check-zsyncmake, why? I removed > the "|| exit" and it worked for me. i didn't intend to include that. gone now. > - /usr/share/doc/zsync contains a duplicate of license (COPYING). Consider > increasing the specificity of %files to "%{_datadir}/doc/%{name}/README"? not installing COPYING there now. simply increasing specificity complains about uncopied files. > - I tried to use the package and had some troubles, but maybe I just didn't > understand the docs. I did this: > $ zsyncmake zsync-0.6.2-1.src.rpm > I then uploaded zsync-0.6.2-1.src.rpm + zsync-0.6.2-1.src.rpm.zsync to > https://samcday.fedorapeople.org/. I then tried this: > $ zsync https://samcday.fedorapeople.org/zsync-0.6.2-1.src.rpm.zsync > failed on url https://samcday.fedorapeople.org/zsync-0.6.2-1.src.rpm.zsync > could not read control file from URL https://samcday.fedorapeople.org/zsync-0.6.2-1.src.rpm.zsync you're using it correctly, but zsync is http-only, it doesn't understand SSL/TLS. I've uploaded a copy to here: http://services.gir.st/pub/zsync-0.6.2-1.fc43.src.rpm.zsync Spec URL: https://girst.fedorapeople.org/zsync.spec SRPM URL: https://girst.fedorapeople.org/zsync-0.6.2-1.fc43.src.rpm -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2356982 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202356982%23c3 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
