https://bugzilla.redhat.com/show_bug.cgi?id=2356145 Jitka Plesnikova <jplesnik@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(jplesnik@redhat.c | |om) | --- Comment #2 from Jitka Plesnikova <jplesnik@xxxxxxxxxx> --- (In reply to Michal Josef Spacek from comment #1) > @jplesnik@xxxxxxxxxx > > Some nits > * The dependency on coreutils is not needed. Sure? It is required for %{_fixperms}, it uses 'chmod'. > * There are two "NO_PACKLIST=1" Good catch, I missed it. > * Regarding the module versions and Perl version used. There are >>use > v5.20;<<, >>"Crypt::URandom" => "0.40"<< and >>"Test::Exception" => > "0.43"<<. Isn't it better to present them in the spec file? I understand > that we don't hit this issue, but for common use, it could be better. I added the version constrain. Updated files are on the same link -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2356145 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202356145%23c2 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
