https://bugzilla.redhat.com/show_bug.cgi?id=2354862 --- Comment #5 from Ondřej Budai <obudai@xxxxxxxxxx> --- I found the following issues during the review, otherwise the package LGTM. Happy to approve when these items get fixed. The changelog version is wrong, please fix it when importing the spec file into dist-git. --- I think you also need to add these runtime deps: - koji-image-builder-builder on koji-builder-plugins - koji-image-builder-hub on koji-hub-plugins - koji-image-builder-cli on python3-koji-cli-plugins This is needed because this package is installing files into directories owned by these packages, see https://docs.fedoraproject.org/en-US/packaging-guidelines/#_the_directory_is_also_owned_by_a_package_implementing_required_functionality_of_your_package --- %pytest macro should be used for invoking tests, see https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_pytest --- %pychached %{_prefix}/lib/koji-hub-plugins/image_builder.py instead of %{_prefix}/lib/koji-hub-plugins/__pycache__/image_builder.* feels slightly cleaner, see https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_source_files_and_bytecode_cache --- %{__python3} should be replaced with %{python3} --- The guidelines recommend using virtual provides like python3dist(pytest) and python3dist(pytest-mock) for test dependencies, see https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_test_dependencies_2 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2354862 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202354862%23c5 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
