[Bug 2297310] Review Request: atuin - magical shell history

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2297310



--- Comment #6 from Michel Lind <michel@xxxxxxxxxxxxxxx> ---
nits:
for the list of licenses, when you have only one license parenthesizing seems
redundant. not a blocker

also not a blocker: on your %files you have
%license LICENSE
%license crates/atuin/LICENSE

^ these files have exactly the same names so they shadow each other. In this
case they are identical (see below) but you just need to list one, not both -
or if they are different, rename one first

$ sha256sum LICENSE crates/atuin/LICENSE
f87d1042ef858e746db8429f69a0cdd9dc73a28595dc738e5cbeb97ad8586d64  LICENSE
f87d1042ef858e746db8429f69a0cdd9dc73a28595dc738e5cbeb97ad8586d64 
crates/atuin/LICENSE


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2297310

Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202297310%23c6

-- 
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux