https://bugzilla.redhat.com/show_bug.cgi?id=2355687 --- Comment #15 from Simone Caronni <negativo17@xxxxxxxxx> --- (In reply to Benson Muite from comment #13) > Comments: > a) Perhaps the documentation can be put in a subpackage? I wouldn't do it, it's just 92kb compressed. Unless it's huge, I usually leave it with the devel subpackages. > b) If > -DGATTLIB_PYTHON_INTERFACE=NO > is changed to > -DGATTLIB_PYTHON_INTERFACE=NO \ > -DCMAKE_SKIP_RPATH=TRUE > > then > BuildRequires: chrpath > and > chrpath -d %{buildroot}%{_bindir}/* > can be removed. Good point. Somehow I remembered that was done by the %cmake macro, but that's not the case. Fixed. > b) Readline seems to be needed: > https://github.com/labapart/gattlib/blob/master/examples/gatttool/CMakeLists. > txt#L55 > https://github.com/labapart/gattlib/tree/master?tab=readme-ov-file#build- > gattlib Yes, but only for gatttool, which does not work properly at the moment so the build is disabled by default: https://github.com/labapart/gattlib/tree/master?tab=readme-ov-file#todo-list Considering the development pace, my guess is that it will never be. > c) License seems like it should be > BSD 2-Clause License AND BSD-3-Clause AND GPL-2.0-or-later AND GPL-2.0-only > AND LGPL-2.1-or-later > > Additional license come from: > > BSD 2-Clause License > -------------------- > gattlib-0.7.2-build/gattlib-0.7.2/bluez/bluez5/src/shared/ecc.c > gattlib-0.7.2-build/gattlib-0.7.2/bluez/bluez5/src/shared/ecc.h > > GNU General Public License, Version 2 > ------------------------------------- > gattlib-0.7.2-build/gattlib-0.7.2/bluez/bluez5/lib/amp.h > > GNU Lesser General Public License v2.1 or later > ----------------------------------------------- > gattlib-0.7.2-build/gattlib-0.7.2/bluez/bluez5/monitor/bt.h > gattlib-0.7.2-build/gattlib-0.7.2/bluez/bluez5/src/shared/ad.c > gattlib-0.7.2-build/gattlib-0.7.2/bluez/bluez5/src/shared/ad.h > gattlib-0.7.2-build/gattlib-0.7.2/bluez/bluez5/src/shared/att-types.h > gattlib-0.7.2-build/gattlib-0.7.2/bluez/bluez5/src/shared/att.c > gattlib-0.7.2-build/gattlib-0.7.2/bluez/bluez5/src/shared/att.h > gattlib-0.7.2-build/gattlib-0.7.2/bluez/bluez5/src/shared/btsnoop.c > gattlib-0.7.2-build/gattlib-0.7.2/bluez/bluez5/src/shared/btsnoop.h > gattlib-0.7.2-build/gattlib-0.7.2/bluez/bluez5/src/shared/crypto.c > gattlib-0.7.2-build/gattlib-0.7.2/bluez/bluez5/src/shared/crypto.h > gattlib-0.7.2-build/gattlib-0.7.2/bluez/bluez5/src/shared/gap.c > gattlib-0.7.2-build/gattlib-0.7.2/bluez/bluez5/src/shared/gap.h > gattlib-0.7.2-build/gattlib-0.7.2/bluez/bluez5/src/shared/gatt-client.c > gattlib-0.7.2-build/gattlib-0.7.2/bluez/bluez5/src/shared/gatt-client.h > gattlib-0.7.2-build/gattlib-0.7.2/bluez/bluez5/src/shared/gatt-db.c > gattlib-0.7.2-build/gattlib-0.7.2/bluez/bluez5/src/shared/gatt-db.h > gattlib-0.7.2-build/gattlib-0.7.2/bluez/bluez5/src/shared/gatt-helpers.c > gattlib-0.7.2-build/gattlib-0.7.2/bluez/bluez5/src/shared/gatt-helpers.h > gattlib-0.7.2-build/gattlib-0.7.2/bluez/bluez5/src/shared/gatt-server.c > gattlib-0.7.2-build/gattlib-0.7.2/bluez/bluez5/src/shared/gatt-server.h > gattlib-0.7.2-build/gattlib-0.7.2/bluez/bluez5/src/shared/hci-crypto.c > gattlib-0.7.2-build/gattlib-0.7.2/bluez/bluez5/src/shared/hci-crypto.h > gattlib-0.7.2-build/gattlib-0.7.2/bluez/bluez5/src/shared/hci.c > gattlib-0.7.2-build/gattlib-0.7.2/bluez/bluez5/src/shared/hci.h > gattlib-0.7.2-build/gattlib-0.7.2/bluez/bluez5/src/shared/hfp.c > gattlib-0.7.2-build/gattlib-0.7.2/bluez/bluez5/src/shared/hfp.h > gattlib-0.7.2-build/gattlib-0.7.2/bluez/bluez5/src/shared/io-glib.c > gattlib-0.7.2-build/gattlib-0.7.2/bluez/bluez5/src/shared/io.h > gattlib-0.7.2-build/gattlib-0.7.2/bluez/bluez5/src/shared/mainloop.c > gattlib-0.7.2-build/gattlib-0.7.2/bluez/bluez5/src/shared/mainloop.h > gattlib-0.7.2-build/gattlib-0.7.2/bluez/bluez5/src/shared/mgmt.c > gattlib-0.7.2-build/gattlib-0.7.2/bluez/bluez5/src/shared/mgmt.h > gattlib-0.7.2-build/gattlib-0.7.2/bluez/bluez5/src/shared/pcap.c > gattlib-0.7.2-build/gattlib-0.7.2/bluez/bluez5/src/shared/pcap.h > gattlib-0.7.2-build/gattlib-0.7.2/bluez/bluez5/src/shared/queue.c > gattlib-0.7.2-build/gattlib-0.7.2/bluez/bluez5/src/shared/queue.h > gattlib-0.7.2-build/gattlib-0.7.2/bluez/bluez5/src/shared/ringbuf.c > gattlib-0.7.2-build/gattlib-0.7.2/bluez/bluez5/src/shared/ringbuf.h > gattlib-0.7.2-build/gattlib-0.7.2/bluez/bluez5/src/shared/tester.c > gattlib-0.7.2-build/gattlib-0.7.2/bluez/bluez5/src/shared/tester.h > gattlib-0.7.2-build/gattlib-0.7.2/bluez/bluez5/src/shared/timeout-glib.c > gattlib-0.7.2-build/gattlib-0.7.2/bluez/bluez5/src/shared/timeout-mainloop.c > gattlib-0.7.2-build/gattlib-0.7.2/bluez/bluez5/src/shared/timeout.h > gattlib-0.7.2-build/gattlib-0.7.2/bluez/bluez5/src/shared/tty.h > gattlib-0.7.2-build/gattlib-0.7.2/bluez/bluez5/src/shared/uhid.c > gattlib-0.7.2-build/gattlib-0.7.2/bluez/bluez5/src/shared/uhid.h > gattlib-0.7.2-build/gattlib-0.7.2/bluez/bluez5/src/shared/util.c > gattlib-0.7.2-build/gattlib-0.7.2/bluez/bluez5/src/shared/util.h This is actually the bluez source code. Packaging guidelines say that the licenses should be based on what is compiled and linked from the sources, so that should not be there. I've removed it in the SPEC file so it's clearer, there's no need to add that license. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2355687 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202355687%23c15 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
