https://bugzilla.redhat.com/show_bug.cgi?id=2354888 --- Comment #11 from Nils Philippsen <nphilipp@xxxxxxxxxx> --- (In reply to Zbigniew Jędrzejewski-Szmek from comment #8) > install -p -D app.ini.tmpl > %{buildroot}%{_sysconfdir}/%{name}/conf/app.ini.tmpl > install -p -D %{S:4} %{buildroot}%{_sysconfdir}/%{name}/public/robots.txt > install -p -D %{name}.complete > %{buildroot}%{_datadir}/bash-completion/completions/%{name} > install -p -D %{S:5} %{buildroot}%{_unitdir}/%{name}.service > install -p -D %{S:6} %{buildroot}%{_sysusersdir}/%{name}.conf > > 'install' unfortunately defaults to mode +x, and this needs to be overridden > with -m 0644 > in all cases where a non-executable file is installed. Oops. I’ll fix that. > The scriptlet that creates the config must be moved out to a separate > service, > see > https://docs.fedoraproject.org/en-US/packaging-guidelines/ > Initial_Service_Setup/. Good to know, I’ll change that, too. > "Any action that must be performed on the system where the service will be > run whose > output is not identical for all systems running that service." > The operation here clearly falls under this definition. > > > %{?sysusers_requires_compat} > > > > %pre > > %sysusers_create_compat %{S:6} > This is only needed in F41-. It's a noop in rawhide now. Please consider > dropping > it in the rawhide branch. Right now I’m targeting not just Rawhide, and I usually keep the branches idential, i.e. differentiate using conditionals (for better or worse), which the macro does already. I could wrap it in another conditional, but that would be pointless, wouldn’t it? > %description is very short. It'd be nice to mention that this package is used > (or will be used) for src.fedoraproject.org. I agree that the description is terse, but I don’t think that our specific use case belongs there – Forgejo itself isn’t Fedora specific and generally useful for our users to run, too. I’ll try to find a snippet on the project website that doesn’t sound too marketing-cringey 😉. > > %attr(0640,-,%{name}) %{_sysconfdir}/%{name}/conf/app.ini.tmpl > Does the template really need to be owned by the user? (And if not, > then the mode can be relaxed too.) Yeah, could be 0644, root, root. > The service: > 1. Can the service be socket-activated? > 2. Type=simple is not great. There is no notification of readinesss. > Type=exec is marginally better. There might be some missing upstream > functionality, but ideally Type=notify or Type=notify-reload would be used. I have to research this. > 3. There is a little bit of sandboxing, but I think more could be added. > Does the service make *outgoing* connections? If not, maybe it could be run > with PrivateNetwork=yes. I need to look if it supports calling web-hooks (which wouldn’t work in this case). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2354888 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202354888%23c11 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
