https://bugzilla.redhat.com/show_bug.cgi?id=2305346 Michal Schorm <mschorm@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(mschorm@xxxxxxxxx | |m) | --- Comment #14 from Michal Schorm <mschorm@xxxxxxxxxx> --- Excludearch: > Is it still necessary to include the `ExcludeArch: %{ix86}` [1]? Yes, MySQL 8.4 is not supported on 32-bit architectures. (Support dropped with first MySQL 8.1 version) --- %global instead of %define: Well, YOU introduced the code there :P https://src.fedoraproject.org/rpms/mysql8.0/c/59a23?branch=rawhide I asked Filip Janus, the original author of the logic, whether he can remember having a particular reason using the %define. I don't see it as a huge problem, but rather a possible enhancement. More than 1350 packages use %define tags in over 4300 places in Fedora, as per sourcegraph search before the search result limit was hit: https://sourcegraph.com/search?q=context:global+repo:%5Esrc.fedoraproject.org/+%25define&patternType=regexp&sm=0 --- Licensing: I agree that the content of the file 'README.mysql-license' should be updated and clarified. I take it as a downstream file, used for informative purposes for Fedora and RHEL consumers. Take a look at the update I've made: https://gitlab.com/mschorm/centos_rpms_mysql8.4/-/commit/35e8a62d7280801f8b3366cfcc33637953afcc35 However the actual current license (the 'The Universal FOSS Exception, Version 1.0') text is part of the LICENSE blob file which we pack. https://src.fedoraproject.org/rpms/mysql8.0/blob/rawhide/f/mysql8.0.spec#_847 So no matter whether we link to the online copy of the license, the > [ ]: Package does not include license text files separate from upstream. check should be satisfied. --- Updated review links Spec URL: https://download.copr.fedorainfracloud.org/results/mschorm/mysql8.4/fedora-rawhide-x86_64/08838319-mysql8.4/mysql8.4.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/mschorm/mysql8.4/fedora-rawhide-x86_64/08838319-mysql8.4/mysql8.4-8.4.4-2.fc43.src.rpm COPR build: https://copr.fedorainfracloud.org/coprs/mschorm/mysql8.4/build/8838319/ Code available at: https://gitlab.com/mschorm/centos_rpms_mysql8.4/-/commits/fedora_review?ref_type=heads -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2305346 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202305346%23c14 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
